Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Result framework and use Swift.Result #174

Merged
merged 1 commit into from
Jul 3, 2019

Conversation

jrcmramos
Copy link
Contributor

Description

This PR introduces the following changes:

  • Remove third party framework Result and use the Swift.Result type

@yonaskolb
Copy link
Owner

Nice one @jrcmramos, thanks for the PR. Alamofire better watch out or it might be next 😀
Though I think some people use that to configure the session.

@yonaskolb yonaskolb merged commit 2251186 into yonaskolb:master Jul 3, 2019
@jrcmramos
Copy link
Contributor Author

Thanks @yonaskolb ! Alamofire would be a really good one in fact! 👍
What do you think we will not be able to configure using NSURLSession?

@yonaskolb
Copy link
Owner

They could still use NSURLSession, but some folks like the extra features like timeline #44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants