Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge pull request #216 from alephao/master #216

Merged
merged 2 commits into from
Feb 1, 2020
Merged

Merge pull request #216 from alephao/master #216

merged 2 commits into from
Feb 1, 2020

Conversation

alephao
Copy link
Contributor

@alephao alephao commented Jan 30, 2020

This PR fixes the issue described on #215

  • Added an extension to Property to get the correct value for the nullable property.
  • Using Property.nullable instead of checking property.required and property.schema.metadata.nullable on SwiftFormatter and CodeFormatter
  • Added a test covering this case

@yonaskolb
Copy link
Owner

Great PR, thanks @alephao! Could you please add a changelog entry and then we can get this merged 👍

@yonaskolb
Copy link
Owner

Adding in master

@yonaskolb yonaskolb changed the title Fix #215 nullable references not rendered as optional Merge pull request #216 from alephao/master Feb 1, 2020
@yonaskolb yonaskolb merged commit 501cde1 into yonaskolb:master Feb 1, 2020
@alephao
Copy link
Contributor Author

alephao commented Feb 3, 2020

Sorry, I was away during the weekend. Thanks!

@yonaskolb yonaskolb mentioned this pull request Mar 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alephao @yonaskolb