Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible reference to MediaItem schema added. #239

Merged
merged 2 commits into from
Mar 30, 2020

Conversation

alexruperez
Copy link
Contributor

@alexruperez alexruperez commented Mar 30, 2020

In order to try to generate mocks #88 of each server response, I have redefined MediaItem schema as a possible reference.

@yonaskolb
Copy link
Owner

Thanks @alexruperez! Could you add a changelog entry as well

@alexruperez
Copy link
Contributor Author

Thanks @yonaskolb, I always forget something! 😅 Done! 🙌

@yonaskolb yonaskolb merged commit ae16a9e into yonaskolb:master Mar 30, 2020
@mackoj mackoj mentioned this pull request Mar 31, 2020
@yonaskolb
Copy link
Owner

@alexruperez this seems to have broken the fixtures. When this PR ran on CI, it didn't fail when it failed to compile the fixtures. I've fixed that so now the errors are properly reported, in the ci branch (also moved to github actions)
Test results can be seen here https://github.com/yonaskolb/SwagGen/runs/582688905?check_suite_focus=true

@alexruperez
Copy link
Contributor Author

Exactly the same error that is happening in #240, it's the Rocket fixture, but I don't know how to fix it. 😞

@yonaskolb
Copy link
Owner

Rocket is the only one not compiling, but the others are broken too I believe. If you look at the diff of this PR there are lots of useless inline models being generated

@yonaskolb
Copy link
Owner

@alexruperez this PR seems to have broken things. I'll need to revert it

yonaskolb added a commit that referenced this pull request Sep 10, 2020
This reverts commit ae16a9e, reversing
changes made to 3bbf15b.

# Conflicts:
#	CHANGELOG.md
yonaskolb added a commit that referenced this pull request Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants