Don't embed frameworks with MACH_O_TYPE=staticlib #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great, thanks @mrabiciu! Could you please add some tests and a changelog entry? |
|
Sure will do! |
mrabiciu
force-pushed
the
static_framework_fixes
branch
2 times, most recently
from
dea0770
to
ef1ee5c
Compare
|
@yonaskolb Added a test and changelog entry |
yonaskolb
reviewed
Jan 12, 2021
mrabiciu
force-pushed
the
static_framework_fixes
branch
from
ef1ee5c
to
5ae60e1
Compare
yonaskolb
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug where if you setup a framework target with
MACH_O_TYPE=staticlibit will incorrectly be added to the "Embed Frameworks" step resulting in duplicated frameworks and a large binary.This change fixes an existing TODO created in: 0afd705 and correctly excludes these targets from the embed phase.