Build universal binaries for release #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yonaskolb
reviewed
Feb 24, 2021
|
|
||
| .PHONY: install build uninstall format_code brew release | ||
|
|
||
| install: build | ||
| mkdir -p $(PREFIX)/bin | ||
| cp -f .build/release/$(EXECUTABLE_NAME) $(INSTALL_PATH) | ||
| cp -f $(shell swift build $(SWIFT_BUILD_FLAGS) --show-bin-path)/$(EXECUTABLE_NAME) $(INSTALL_PATH) |
There was a problem hiding this comment.
Also TIL about shell swift ...👀
|
This is great, thank you @thii. Could you rebase off or merge in master and then add a changelog entry (since you'll get a conflict in the changelog otherwise) |
thii
force-pushed
the
build-universal-binaries-for-release
branch
from
1be1186
to
0ce381e
Compare
|
@yonaskolb Thanks. Rebased and added a changelog entry. I added it to the "Internal" section, but let me know if that isn't the right place. |
yonaskolb
approved these changes
Feb 25, 2021
|
This is unfortunately causing issues with Homebrew Homebrew/homebrew-core#74854 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #994.