Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code sign on copy #324

Merged
merged 2 commits into from
Jun 27, 2018
Merged

Code sign on copy #324

merged 2 commits into from
Jun 27, 2018

Conversation

yonaskolb
Copy link
Owner

Fixes #315

This only sets CodeSignOnCopy on non target embeds by default. It still respects an explicit Dependency.codeSign

@yonaskolb yonaskolb mentioned this pull request Jun 27, 2018
Closed
alvarhansen
alvarhansen approved these changes Jun 27, 2018
View reviewed changes
Copy link
Contributor

@alvarhansen alvarhansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can't find anything to comment on.

@yonaskolb yonaskolb merged commit 0567bea into master Jun 27, 2018
@yonaskolb yonaskolb deleted the code_sign_on_copy branch June 27, 2018 23:36
@erikkerber
Copy link

LOL I was about to bug/fix this myself 😆

@yonaskolb
Copy link
Owner Author

@eskerber Would you of done it this way? I can’t be certain that the default of whether to code sign is correct

@erikkerber
Copy link

erikkerber commented Jun 28, 2018 •
edited
Loading

@yonaskolb Kind of. I was going to use the same logic that buckets the extensions array to determine which should not be codesigned.

As a coworker of mine pointed out Xcode goes so far as to hide the code sign option in Xcode if the object being copied is an app extension:

2018-06-27 at 7 30 pm

@yonaskolb
Copy link
Owner Author

Perhaps the decision could be based on the destination. So anything in Plugins wouldn't have code sign on copy

@erikkerber erikkerber mentioned this pull request Jul 3, 2018
Closed
@yonaskolb yonaskolb mentioned this pull request Jul 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarhansen alvarhansen alvarhansen approved these changes

@toshi0383 toshi0383 toshi0383 approved these changes

@kastiglione kastiglione Awaiting requested review from kastiglione

@keith keith Awaiting requested review from keith

@rahul-malik rahul-malik Awaiting requested review from rahul-malik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yonaskolb @erikkerber @alvarhansen @toshi0383