Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes XPC Service package type to XPC! #435

Merged
merged 1 commit into from Nov 5, 2018

Conversation

alvarhansen
Copy link
Contributor

According to Xcode templates, the package type for XPC Service is XPC!.
And App Extension template inherits from XCP Service Base.

When trying to run App Extension in simulator with package type XPC I get following error:
Appex bundle at /Users/alvarhansen/Library/Developer/CoreSimulator/Devices/4ABE6541-2875-40E3-A7DC-BAD7F8AC274B/data/Library/Caches/com.apple.mobile.installd.staging/temp.w9qEII/extracted/myappwithxpc.app/PlugIns/Today.appex with id com.monese.myappwithxpc.Today has an illegal value for the CFBundlePackageType key in its Info.plist: XPC

Copy link
Owner

@yonaskolb yonaskolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @alvarhansen!

case .xpcService:
targetInfoPlist["CFBundlePackageType"] = "XPC"
case .xpcService,
.appExtension:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: indenting

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Can't wait for better swift package generate-xcodeproj that supports usesTabs: false 😄

Includes app extension as XPC type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants