Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need carthage copy-frameworks for macOS app #76

Merged

Conversation

toshi0383
Copy link
Collaborator

@yonaskolb
Copy link
Owner

Interesting. I don't have much experience with macOS development so I missed this. It looks like we'd need to also have a script that copies the dYSM files as well for macOS targets.
Do you feel up to adding that?

@toshi0383
Copy link
Collaborator Author

toshi0383 commented Sep 29, 2017

I've never uploaded frameworks' dSYMs for my Mac apps actually, so maybe not now. 🙃
I can investigate later, though. I'm going to make a new release for Swift4 anyways.(later this year..)

@yonaskolb
Copy link
Owner

Ok, I'll merge this for now. About to do a hotfix release

@yonaskolb yonaskolb merged commit 4227ac2 into yonaskolb:master Sep 29, 2017
@toshi0383 toshi0383 deleted the ts-no-need-copy-frameworks-for-macos branch September 29, 2017 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants