Fixed issue when linking and embeding static frameworks

[acecilia]

From what I understand, static frameworks are:

1. Linked as usual (to be able to use them)
2. Never embed, as their binary becomes part of the binary that depends on them

For example, given this (SwiftModule1, SwiftModule2 and SwiftModule3 are static frameworks; SnapKit is a dynamic one):

options:
  transitivelyLinkDependencies: true

targets:
  SwiftModule1:
    type: framework.static
    ...
    dependencies:
    - framework: SwiftModule2.framework
      implicit: true
      embed: false
    - framework: ../../Carthage/Build/iOS/SnapKit.framework
  SwiftModule1Tests:
    type: bundle.unit-test
    ...
    dependencies:
    - target: SwiftModule1
    - framework: SwiftModule3.framework
      implicit: true
      embed: false
      

In the target SwiftModule1Tests, when generating the xcode project you find that:

• Link binary with libraries: SnapKit, SwiftModule1, SwiftModule3
• Embed frameworks: SnapKit, SwiftModule1

I believe that is wrong, and instead it should be:

• Link binary with libraries: SnapKit, SwiftModule1, SwiftModule2, SwiftModule3
• Embed frameworks: SnapKit

[yonaskolb]

Thanks @acecilia!
@brentleyjones does this look right to you? You did a lot of the static library work

[acecilia]

Build not working due to tuist/XcodeProj#536

[acecilia]

Oh sorry, I am not familiar with Github PR reviews, and I had comments explaining the code (which I made yesterday) but did not press in "Submit review" :/

[brentleyjones]

After the dependency.embed != true is propagated more (and more tests are written if needed to ensure nothing breaks from that), this is good to good from my PoV. Thanks @acecilia!

[acecilia]

This is ready to go :)

[brentleyjones]

@acecilia Please rebase to resolve conflicts.

[acecilia]

@brentleyjones done :)

[brentleyjones]

Thanks @acecilia for this fix!