Allow skipping compile source build phase for bundles

[nkukushkin]

Motivation

We’ve added a resource bundle to our app and this caused the following issue when uploading to the ASC:

ERROR ITMS-90171: "Invalid Bundle Structure - The binary file 'XXX.app/YYYY.bundle/YYYY' is not permitted. Your app can't contain standalone executables or libraries, other than a valid CFBundleExecutable of supported bundles. Refer to the Bundle Programming Guide at https://developer.apple.com/go/?id=bundle-structure for information on the iOS app bundle structure."

We solved this by removing CFBundleExecutable parameter from the bundle’s Info.plist file (as per default behaviour described in xcodegen docks) and Compile Sources build phase from the its target. However, when we use xcodegen, the Compile Sources build phase comes back, even though it’s empty.

Judging by the source it seems impossible to make xcodegen skip Compile Sources unless the target’s type is hardcoded in canSkipCompileSourcesBuildPhase.

This issue is very similar to #149

Solution

I propose adding bundle to the list of types whose canSkipCompileSourcesBuildPhase property returns true.

[yonaskolb]

Great, thanks @nkukushkin! Could you add a changelog entry as well?

[nkukushkin]

Done 👌