Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff/Download folder is broken #60

Closed
wyqydsyq opened this issue Nov 18, 2014 · 6 comments
Closed

Diff/Download folder is broken #60

wyqydsyq opened this issue Nov 18, 2014 · 6 comments
Assignees
Labels

Comments

@wyqydsyq
Copy link

When trying to download via either Download Folder or Diff Folder, I get the following error:

TypeError: Cannot read property 'forEach' of undefined
  at /home/damon/.atom/packages/remote-sync/lib/transports/FtpTransport.coffee:86:15
  at /home/damon/.atom/packages/atom-beautify/node_modules/analytics-node/node_modules/superagent-proxy/node_modules/proxy-agent/node_modules/pac-proxy-agent/node_modules/get-uri/node_modules/ftp/lib/connection.js:439:14
  at /home/damon/.atom/packages/atom-beautify/node_modules/analytics-node/node_modules/superagent-proxy/node_modules/proxy-agent/node_modules/pac-proxy-agent/node_modules/get-uri/node_modules/ftp/lib/connection.js:891:7
  at Socket.<anonymous> (/home/damon/.atom/packages/atom-beautify/node_modules/analytics-node/node_modules/superagent-proxy/node_modules/proxy-agent/node_modules/pac-proxy-agent/node_modules/get-uri/node_modules/ftp/lib/connection.js:922:5)
  at Socket.g (events.js:199:16)
  at Socket.emit (events.js:104:17)
  at Object.afterConnect [as oncomplete] (net.js:973:10)

Uploading/downloading files directly works fine.

A wild stab in the dark is that the forEach that's throwing the error is expecting a collection of remote files but is getting undefined - possible the extension isn't receiving a remote equivalent of ls correctly.

@yongkangchen
Copy link
Owner

@Gawdl3y can you take a look at this?

@Gawdl3y
Copy link
Collaborator

Gawdl3y commented Nov 19, 2014

I'll look into it ASAP.

On Tue, Nov 18, 2014, 8:56 PM Yongkang Chen notifications@github.com
wrote:

@Gawdl3y https://github.com/Gawdl3y can you take a look at this?


Reply to this email directly or view it on GitHub
#60 (comment)
.

@Gawdl3y
Copy link
Collaborator

Gawdl3y commented Nov 19, 2014

I've been unable to reproduce this issue. Does it occur under specific conditions?

@wyqydsyq
Copy link
Author

I can't see anything that would make it specific.

I'm using OpenSUSE 13.2, Atom 0.140.0, Remote Sync 2.1.4

I played around a bit more and found that after trying to download/upload/diff a folder, anything I try to do afterwards regarding this extension (even uploading/downloading single files which usually works) also spawns the same error.

When trying to use the plugin after the initial error, it also says Error: unable to make data connection in the Remote Sync panel, as well as spawning another TypeError.

Here's a webm to help explain what's going on:

http://a.pomf.se/qlraxf.webm

@yongkangchen
Copy link
Owner

@wyqydsyq is this issue still? After google: Error: unable to make data connection, I guess it has something to do with passive mode?

@elistone
Copy link
Contributor

elistone commented May 9, 2016

There has been no response to this ticket as such it will now be closed.
If the still issue still exists please reply and we will look into it.

@elistone elistone closed this as completed May 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants