Close ID pool when closing client #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For every client that `SimpleClientFactory` creates, a goroutine is started for the `idPool`. When you call `client.Close()` the connection is closed but the `idPool` remains running. With this change, the `idPool` is properly closed. Co-authored-by: Adrian Philipp <adri@users.noreply.github.com>
ruudk
force-pushed
the
close-ids-pool-on-client-close
branch
from
d0e57c7
to
26b1b08
Compare
|
This is a nice addition. Please rebase to the latest master branch and I will merge this. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For every client that
SimpleClientFactorycreates, a goroutine is started for theidPool.When you call
client.Close()the connection is closed but theidPoolremains running.With this change, the
idPoolis properly closed.Found together with @adri in #48