Skip to content

Исправлен баг в ArtifactVersionResolver #4

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

layfe
Copy link
Contributor

@layfe layfe commented Mar 10, 2021

No description provided.

@layfe layfe requested a review from a team March 10, 2021 19:01
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #4 (c4cb0e6) into master (8b64729) will decrease coverage by 0.06%.
The diff coverage is 76.92%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #4      +/-   ##
============================================
- Coverage     89.33%   89.26%   -0.07%     
- Complexity      449      455       +6     
============================================
  Files            60       60              
  Lines          1247     1267      +20     
  Branches         92       94       +2     
============================================
+ Hits           1114     1131      +17     
- Misses           84       86       +2     
- Partials         49       50       +1     
Impacted Files Coverage Δ Complexity Δ
.../library/dependencies/ArtifactVersionResolver.java 84.78% <76.92%> (+0.16%) 15.00 <3.00> (+6.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f172f5...c4cb0e6. Read the comment docs.

CHANGELOG.md Outdated
### NEXT_VERSION_DESCRIPTION_BEGIN
* Исправлен баг в ArtifactVersionResolver - при поиске в списке репозиториев пропускаем репозитории, получение версий из которого
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Формулировка двойственная. Непонятно какое поведение теперь. Мы теперь пропускаем репозиторий или наоборот нет.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

уточнила

f0y
f0y previously approved these changes Mar 10, 2021
@layfe layfe merged commit 5786668 into master Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants