Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong leading slash for absolute paths #1

Closed
buzinas opened this issue May 2, 2019 · 3 comments
Closed

Wrong leading slash for absolute paths #1

buzinas opened this issue May 2, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@buzinas
Copy link

buzinas commented May 2, 2019

See 2e79812#r33386432

@yoriiis
Copy link
Owner

yoriiis commented May 9, 2019

Hello @buzinas thanks for the issue 👍

It's a mistake, I think the statement below is no longer necessary:

if(this.publicPath.substr(0, 1) !== '/'){
    this.publicPath = `/${this.publicPath}`;
}

The slash must be directly entered by the user in the Webpack publicPath configuration.
I will update the code

yoriiis pushed a commit that referenced this issue May 9, 2019
@yoriiis
Copy link
Owner

yoriiis commented May 9, 2019

The fix is up to date in the version 2.0.1

@yoriiis yoriiis closed this as completed May 9, 2019
@buzinas
Copy link
Author

buzinas commented May 9, 2019

Thanks!

@yoriiis yoriiis added the bug Something isn't working label May 9, 2019
yoriiis added a commit that referenced this issue Mar 24, 2020
yoriiis added a commit that referenced this issue Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants