Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix llrb tree error #147

Merged
merged 2 commits into from Jan 29, 2024
Merged

Fix llrb tree error #147

merged 2 commits into from Jan 29, 2024

Conversation

humdrum
Copy link
Contributor

@humdrum humdrum commented Jan 29, 2024

What this PR does / why we need it:

  • Correct incorrectly ported code.
  • Set "inout" for the Node parameter to apply changes.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@humdrum humdrum added the bug 🐞 Something isn't working label Jan 29, 2024
@humdrum humdrum self-assigned this Jan 29, 2024
Copy link
Contributor

@myupage myupage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 114 lines in your changes are missing coverage. Please review.

Comparison is base (b1d58ea) 42.58% compared to head (43763e4) 42.44%.
Report is 4 commits behind head on main.

Files Patch % Lines
Tests/Integration/TreeIntegrationTests.swift 0.00% 99 Missing ⚠️
Sources/Document/CRDT/CRDTTree.swift 0.00% 10 Missing ⚠️
Sources/Util/LLRBTree.swift 86.95% 3 Missing ⚠️
Sources/Document/Json/JSONTree.swift 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
- Coverage   42.58%   42.44%   -0.14%     
==========================================
  Files         104      104              
  Lines       24276    24326      +50     
==========================================
- Hits        10338    10326      -12     
- Misses      13938    14000      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@humdrum humdrum merged commit 9eb6b47 into main Jan 29, 2024
3 checks passed
@humdrum humdrum deleted the fix-llrb-tree branch January 29, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants