-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Document.GarbageCollect
in JS SDK
#38
Comments
@hackerwins Hello. Could I try this issue? |
@mojosoeun Yes of course. Please let me know if you need help. |
How is this going? |
I havent started this issue but I will start it soon due to some other work. I will let you know if I need help! Thanks! |
@hackerwins I found this issue, I was wondering this issue affects implementing garbage collection in JS SDK? |
@mojosoeun Since GC is performed independently for each replica, It seems that the GC issue does not directly affect the JS SDK. However, when we actually remove an element marked for deletion, we should be careful not to leave a reference to the removed element in the clone. If there are no references to the deleted object left, the object is likely to be deleted by the JavaScript runtime. |
Not long ago we introduced the Garbage Collection feature in Yorkie.
And we implemented Document.GarbageCollect in Go.
We also need to implement
Document.GarbageCollect
function in JS SDK. Then we need to add logic to execute GarbageCollect by receiving the MinSyncedTicket in PushPull's response.The text was updated successfully, but these errors were encountered: