Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Document.GarbageCollect in JS SDK #38

Closed
hackerwins opened this issue Jun 6, 2020 · 6 comments · Fixed by #101
Closed

Implement Document.GarbageCollect in JS SDK #38

hackerwins opened this issue Jun 6, 2020 · 6 comments · Fixed by #101
Assignees
Labels
enhancement 🌟 New feature or request good first issue 🐤 Good for newcomers
Projects

Comments

@hackerwins
Copy link
Member

Not long ago we introduced the Garbage Collection feature in Yorkie.

And we implemented Document.GarbageCollect in Go.

We also need to implement Document.GarbageCollect function in JS SDK. Then we need to add logic to execute GarbageCollect by receiving the MinSyncedTicket in PushPull's response.

@hackerwins hackerwins added enhancement 🌟 New feature or request good first issue 🐤 Good for newcomers labels Jun 6, 2020
@mojosoeun
Copy link
Member

@hackerwins Hello. Could I try this issue?

@hackerwins
Copy link
Member Author

@mojosoeun Yes of course. Please let me know if you need help.

@semin-park
Copy link
Contributor

How is this going?
I'm also interested in this issue, so if there's anything I can help with, please let me know!

@mojosoeun
Copy link
Member

I havent started this issue but I will start it soon due to some other work.

I will let you know if I need help! Thanks!

@hackerwins hackerwins added this to To do in v0.1 Sep 28, 2020
@hackerwins hackerwins moved this from To do to In progress in v0.1 Sep 28, 2020
@hackerwins hackerwins moved this from In progress to To do in v0.1 Sep 28, 2020
@mojosoeun mojosoeun moved this from To do to In progress in v0.1 Oct 31, 2020
@mojosoeun mojosoeun self-assigned this Oct 31, 2020
@mojosoeun
Copy link
Member

@hackerwins I found this issue, I was wondering this issue affects implementing garbage collection in JS SDK?

@hackerwins
Copy link
Member Author

@mojosoeun Since GC is performed independently for each replica, It seems that the GC issue does not directly affect the JS SDK.

However, when we actually remove an element marked for deletion, we should be careful not to leave a reference to the removed element in the clone. If there are no references to the deleted object left, the object is likely to be deleted by the JavaScript runtime.

mojosoeun added a commit to mojosoeun/yorkie-js-sdk that referenced this issue Nov 10, 2020
mojosoeun added a commit to mojosoeun/yorkie-js-sdk that referenced this issue Nov 10, 2020
v0.1 automation moved this from In progress to Done Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🌟 New feature or request good first issue 🐤 Good for newcomers
Projects
No open projects
v0.1
Done
Development

Successfully merging a pull request may close this issue.

3 participants