Remove unnecessary checkpoint validation from applyChangePack #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we trust the server's response, we can apply the checkpoint received from it without further verification
Codecov Report
@@ Coverage Diff @@
## main #497 +/- ##
==========================================
- Coverage 90.25% 90.25% -0.01%
==========================================
Files 70 70
Lines 6148 6145 -3
Branches 578 576 -2
==========================================
- Hits 5549 5546 -3
Misses 388 388
Partials 211 211
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
hackerwins
approved these changes
Apr 18, 2023
This was referenced Jun 9, 2023
hunkim98
pushed a commit
to hunkim98/yorkie-js-sdk
that referenced
this pull request
Jul 12, 2023
…-team#497) Since we trust the server's response, we can apply the checkpoint received from it without further verification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Remove unnecessary checkpoint validation from applyChangePack.
Since we trust the server's response, we can apply the checkpoint
received from it without further verification.
Any background context you want to provide?
What are the relevant tickets?
Fixes #
Checklist