Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quill example page image rendering issue #504

Conversation

JOOHOJANG
Copy link
Contributor

@JOOHOJANG JOOHOJANG commented Apr 20, 2023

What this PR does / why we need it?

reported by @chacha912 (#491)

The cause of this issue is that JSON.stringify method is invoked twice.

Object {image: "data:..."} is over-stringified ('"{"image": "data:...."}"')
Therefore, I removed the previously called part because it calls JSON.stringify anyway.

Any background context you want to provide?

What are the relevant tickets?

Fixes #491

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #504 (f0111de) into main (3b313a5) will increase coverage by 0.47%.
The diff coverage is 87.75%.

@@            Coverage Diff             @@
##             main     #504      +/-   ##
==========================================
+ Coverage   89.69%   90.17%   +0.47%     
==========================================
  Files          69       70       +1     
  Lines        5669     6145     +476     
  Branches      549      576      +27     
==========================================
+ Hits         5085     5541     +456     
- Misses        390      392       +2     
- Partials      194      212      +18     
Impacted Files Coverage Δ
src/client/attachment.ts 77.77% <0.00%> (+1.03%) ⬆️
src/document/crdt/array.ts 81.81% <0.00%> (-1.91%) ⬇️
src/document/json/array.ts 86.43% <0.00%> (-1.33%) ⬇️
src/document/operation/operation.ts 100.00% <ø> (ø)
test/helper/helper.ts 82.22% <ø> (+8.14%) ⬆️
test/integration/object_test.ts 100.00% <ø> (ø)
src/client/client.ts 73.53% <25.00%> (-0.97%) ⬇️
src/document/operation/select_operation.ts 50.00% <42.85%> (+11.11%) ⬆️
src/document/operation/style_operation.ts 54.16% <50.00%> (+4.16%) ⬆️
src/document/operation/increase_operation.ts 66.66% <57.14%> (+2.38%) ⬆️
... and 13 more

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hackerwins hackerwins self-requested a review April 21, 2023 00:38
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. 👍

@hackerwins hackerwins merged commit be161cc into yorkie-team:main Apr 21, 2023
1 check passed
hunkim98 pushed a commit to hunkim98/yorkie-js-sdk that referenced this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with image attachment in the Quill example
2 participants