Fix quill example page image rendering issue #504
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
reported by @chacha912 (#491)
The cause of this issue is that
JSON.stringify
method is invoked twice.yorkie-js-sdk/src/document/crdt/text.ts
Line 472 in 5a0d2b4
yorkie-js-sdk/public/quill.html
Line 173 in 5a0d2b4
Object
{image: "data:..."}
is over-stringified ('"{"image": "data:...."}"'
)Therefore, I removed the previously called part because it calls
JSON.stringify
anyway.Any background context you want to provide?
What are the relevant tickets?
Fixes #491
Checklist