-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for OperationInfo inference on Document.subscribe #535
Merged
hackerwins
merged 6 commits into
main
from
feat/support-subscribe-path-type-to-infer-operation
Jun 16, 2023
Merged
Support for OperationInfo inference on Document.subscribe #535
hackerwins
merged 6 commits into
main
from
feat/support-subscribe-path-type-to-infer-operation
Jun 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #535 +/- ##
==========================================
- Coverage 88.08% 87.93% -0.16%
==========================================
Files 77 77
Lines 7386 7432 +46
Branches 713 727 +14
==========================================
+ Hits 6506 6535 +29
- Misses 607 614 +7
- Partials 273 283 +10
|
hackerwins
force-pushed
the
feat/support-subscribe-path-type-to-infer-operation
branch
from
June 16, 2023 06:13
857f895
to
3a7bc0b
Compare
hackerwins
changed the title
support subscribe path type
Support for OperationInfo inference on Document.subscribe
Jun 16, 2023
hackerwins
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
This will provide a more convenient way to use document.Subscribe
.
hackerwins
deleted the
feat/support-subscribe-path-type-to-infer-operation
branch
June 16, 2023 06:28
hunkim98
pushed a commit
to hunkim98/yorkie-js-sdk
that referenced
this pull request
Jul 12, 2023
…m#535) Co-authored-by: Youngteac Hong <susukang98@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
To make it easier to get the message when using
doc.subscribe
, we specify the type.we get the type of $.text by referencing Document<{ text: Text } >.
It adds two new features
Any background context you want to provide?
Knowing in advance that an Operation is going to be subject to certain changes makes it easier to adapt.
What are the relevant tickets?
Fixes #521
Checklist