-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the value of XXXChange to Change in Document.subscribe #538
Conversation
Codecov Report
@@ Coverage Diff @@
## main #538 +/- ##
==========================================
- Coverage 88.10% 88.08% -0.02%
==========================================
Files 77 77
Lines 7397 7386 -11
Branches 714 713 -1
==========================================
- Hits 6517 6506 -11
Misses 607 607
Partials 273 273
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
Would it be possible for you to test all the examples too? It appears that there might be a small typo in public/editor.html.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
…-team#538) Previously, we passed ChangeInfos as values of RemoteChange and LocalChange types in Document.subscribe, and users should iterate loop to extract Change. This commit simply passes Change instead of Changes to remove changes loop in Document.subscribe. --------- Co-authored-by: Youngteac Hong <susukang98@gmail.com>
What this PR does / why we need it?
It's reduce changes loop when local-change and remote-change are fired
Any background context you want to provide?
What are the relevant tickets?
Fixes #537
Checklist