-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add peer selection display example #544
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #544 +/- ##
==========================================
- Coverage 87.99% 87.75% -0.25%
==========================================
Files 77 77
Lines 7372 7464 +92
Branches 712 731 +19
==========================================
+ Hits 6487 6550 +63
- Misses 612 630 +18
- Partials 273 284 +11
|
hackerwins
force-pushed
the
feat/tree-selection-presence
branch
2 times, most recently
from
June 16, 2023 08:01
edb4ddf
to
5fdd8fb
Compare
hackerwins
force-pushed
the
feat/tree-selection-presence
branch
from
June 16, 2023 08:09
5fdd8fb
to
63ed1c6
Compare
hackerwins
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
hackerwins
changed the title
Implement to make tree selection info
Add peer selection display example
Jun 16, 2023
2 tasks
hunkim98
pushed a commit
to hunkim98/yorkie-js-sdk
that referenced
this pull request
Jul 12, 2023
Co-authored-by: Youngteac Hong <susukang98@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Allows selection information from the
yorkie.Tree
to be sent remotely.support remote selection viewer.
Any background context you want to provide?
Tree selection information is provided by the createRange () function.
The selection is converted to a string for transmission to the remote.
As you can see in the code, there is no way to simply send pos, so we wrap it in Primitive.of.
The reason for this is so that we can transform it into bytes and send it.
The converted selection information is then sent via root.selection to root.tree in the same way as root.tree.
There's a problem: the selection information is an array, which generates quite a few operations.
Set
,Add
,Add
At least three things must be done, because range information has from and to.
2023-06-14.5.17.30.mov
What are the relevant tickets?
Fixes #543
Checklist