Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pathToTreePos TC #571

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Fix pathToTreePos TC #571

merged 2 commits into from
Jul 14, 2023

Conversation

JOOHOJANG
Copy link
Contributor

@JOOHOJANG JOOHOJANG commented Jul 14, 2023

What this PR does / why we need it?

  • remove skip and let test case run properly

Any background context you want to provide?

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@JOOHOJANG JOOHOJANG marked this pull request as ready for review July 14, 2023 07:24
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you merge the main branch to fix CI error?

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #571 (2657618) into main (edf018a) will increase coverage by 0.50%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #571      +/-   ##
==========================================
+ Coverage   87.51%   88.02%   +0.50%     
==========================================
  Files          79       79              
  Lines        7820     7814       -6     
  Branches      781      781              
==========================================
+ Hits         6844     6878      +34     
+ Misses        661      622      -39     
+ Partials      315      314       -1     
Impacted Files Coverage Δ
test/unit/util/index_tree_test.ts 100.00% <100.00%> (+21.21%) ⬆️

... and 1 file with indirect coverage changes

@hackerwins hackerwins self-requested a review July 14, 2023 08:15
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

@JOOHOJANG JOOHOJANG requested review from hackerwins and removed request for hackerwins July 14, 2023 08:16
@hackerwins hackerwins merged commit 0d92f64 into main Jul 14, 2023
2 checks passed
@hackerwins hackerwins deleted the fix/path-to-treepos-tc branch July 14, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants