Concurrent case handling for Yorkie.tree #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
* Change 'Documents' from plural to singular in DocEvent * Specify event triggerd in applyChanges
…team/yorkie-js-sdk into concurrent-case-handling
* Remove unused client id(key) from API response * Change clientID type from bytes to string in the API
…team/yorkie-js-sdk into concurrent-case-handling
|
@sejongk Could you sign the CCLA? |
2 tasks
banma1234
added a commit
to banma1234/yorkie-js-sdk
that referenced
this pull request
Aug 21, 2023
Concurrent case handling for Yorkie.tree (yorkie-team#611)
banma1234
added a commit
to banma1234/yorkie-js-sdk
that referenced
this pull request
Aug 21, 2023
Concurrent case handling for Yorkie.tree (yorkie-team#611)
2 tasks
2 tasks
2 tasks
2 tasks
hackerwins
added a commit
that referenced
this pull request
Jan 30, 2024
The root cause of the issue was related to the use of getLastTimeTicket within posRangeToIndexRange(Ref: #611). To find nodes, the function findNodesAndSplitText was used, which includes a process to determine the position when inserting nodes, requiring a TimeTicket as a reference. However, for posRangeToIndexRange, which involves simple retrieval without node insertion, this logic was unnecessary. Consequently, This commit made modifications to exclude this specific logic. --------- Co-authored-by: Youngteac Hong <susukang98@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Introduced new logical timestamp for identifying position in local/remote editing, and ensures commutative editing in concurrent cases.
Any background context you want to provide?
This logical timestamp consists of {parentID, leftSiblingID}. This allows editing at the front of text nodes by using a reference to the parent, as well as getting rid of the local offset used to access an element node's children previously by using the leftSiblingID.
What are the relevant tickets?
Address yorkie-team/yorkie#559
Checklist