Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable realtime sync in gc test #656

Merged

Conversation

sejongk
Copy link
Contributor

@sejongk sejongk commented Sep 24, 2023

What this PR does / why we need it?

This PR disables real-time sync in the GC test by using the { isRealtimeSync: false } option.
While the test has luckily passed under ideal conditions, occasional failures could occur due to external factors, such as network latency.
Additionally, I've updated the equality assertion functions to align with the JS interface, which follows the pattern assert.equal(actual, expected). These changes should improve code consistency and make debugging easier.

Any background context you want to provide?

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.08% ⚠️

Comparison is base (795cd30) 89.21% compared to head (4716d60) 89.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #656      +/-   ##
==========================================
- Coverage   89.21%   89.13%   -0.08%     
==========================================
  Files          79       79              
  Lines        9318     9318              
  Branches      856      856              
==========================================
- Hits         8313     8306       -7     
- Misses        693      698       +5     
- Partials      312      314       +2     
Files Changed Coverage Δ
test/integration/gc_test.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hackerwins hackerwins self-requested a review September 24, 2023 23:37
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@hackerwins hackerwins merged commit 5b71425 into yorkie-team:main Sep 24, 2023
2 checks passed
hackerwins pushed a commit that referenced this pull request Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants