Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create-yorkie-app #690

Merged
merged 16 commits into from
Nov 25, 2023
Merged

create-yorkie-app #690

merged 16 commits into from
Nov 25, 2023

Conversation

blurfx
Copy link
Member

@blurfx blurfx commented Nov 18, 2023

What this PR does / why we need it?

Pulled the create-yorkie-app branch that @se030 worked, to fix ci failing issue.

Any background context you want to provide?

See #643

What are the relevant tickets?

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@blurfx blurfx self-assigned this Nov 18, 2023
@blurfx blurfx changed the title Create yorkie app create-yorkie-app Nov 18, 2023
Copy link

codecov bot commented Nov 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e11047d) 69.10% compared to head (0494fec) 69.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #690      +/-   ##
==========================================
+ Coverage   69.10%   69.12%   +0.02%     
==========================================
  Files          58       58              
  Lines        8787     8787              
  Branches      800      800              
==========================================
+ Hits         6072     6074       +2     
+ Misses       2455     2454       -1     
+ Partials      260      259       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blurfx
Copy link
Member Author

blurfx commented Nov 18, 2023

I think a problem has been fixed on 953c372.

ref: vercel/turbo#4183

@se030 se030 mentioned this pull request Nov 20, 2023
2 tasks
@hackerwins
Copy link
Member

hackerwins commented Nov 21, 2023

@se030 I have temporarily granted permission to push to this branch until this PR is merged.

@blurfx, @se030 I have two comments:

A. If the JS SDK examples are directly included in the create-yorkie-app release, we should consider it has dependencies on the JS SDK. If so, it would be good to use the same version as the JS SDK. Checking the version of create-yorkie-app can help determine which version of the JS SDK it refers to.

B. It seems that create-yorkie-app is a CLI. How do you plan to release it? If it is to be installed using npm -g create-yorkie-app, do we need to add a new package to npm?

@blurfx
Copy link
Member Author

blurfx commented Nov 21, 2023

@hackerwins
A. Agree. currently, examples are included in the create-yorkie-app build, so I think it would be good to follow the same version. and if in the future create-yorkie-app can create an empty project too(boilerplate?), I think this case could be approached differently.

B. Yes, it should be deployed to npm.

@blurfx blurfx assigned blurfx and se030 and unassigned blurfx Nov 25, 2023
@blurfx blurfx requested a review from se030 November 25, 2023 12:07
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@hackerwins hackerwins merged commit ae97b8d into main Nov 25, 2023
2 checks passed
@hackerwins hackerwins deleted the create-yorkie-app branch November 25, 2023 13:50
hackerwins pushed a commit that referenced this pull request Nov 25, 2023
Provides CLI starter kit to allow npm users to conveniently scaffold
yorkie-based cooperative apps
hackerwins pushed a commit that referenced this pull request Nov 25, 2023
Provides CLI starter kit to allow npm users to conveniently scaffold
yorkie-based cooperative apps
hackerwins pushed a commit that referenced this pull request Nov 25, 2023
Provides CLI starter kit to allow npm users to conveniently scaffold
yorkie-based cooperative apps
@hackerwins
Copy link
Member

I published manually create-yorkie-app to npm. And then I could see the package below.
https://www.npmjs.com/package/create-yorkie-app

After that, I was able to install create-yorkie-app with npm install -g. But when I execute the CLI, I get the following error.

Screenshot 2023-11-25 at 11 02 14 PM

Did I miss anything?

hackerwins pushed a commit that referenced this pull request Nov 25, 2023
Provides CLI starter kit to allow npm users to conveniently scaffold
yorkie-based cooperative apps

---------

Co-authored-by: se030 <se030.kim@gmail.com>
@hackerwins hackerwins added the documentation 📔 Improvements or additions to documentation label Nov 25, 2023
hackerwins pushed a commit that referenced this pull request Nov 25, 2023
Provides CLI starter kit to allow npm users to conveniently scaffold
yorkie-based cooperative apps

---------

Co-authored-by: se030 <se030.kim@gmail.com>
@blurfx
Copy link
Member Author

blurfx commented Nov 25, 2023

There seems to be a problem with the code in the overwriting the environment variable file.

@blurfx blurfx mentioned this pull request Nov 25, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📔 Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants