Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid tree conversion #719

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Conversation

hackerwins
Copy link
Member

@hackerwins hackerwins commented Jan 8, 2024

What this PR does / why we need it?

Fix invalid tree conversion

A script error occurred when creating a snapshot due to a typo in the converter during migrating to connectRPC. This commit fixes the typo.

@JOOHOJANG Thanks for your reporting.

Any background context you want to provide?

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (a882a68) 82.03% compared to head (8adb93b) 82.03%.

Files Patch % Lines
src/api/converter.ts 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #719   +/-   ##
=======================================
  Coverage   82.03%   82.03%           
=======================================
  Files          57       57           
  Lines        4231     4231           
  Branches      828      828           
=======================================
  Hits         3471     3471           
  Misses        502      502           
  Partials      258      258           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hackerwins hackerwins marked this pull request as ready for review January 8, 2024 03:16
@hackerwins hackerwins merged commit 7e339b0 into main Jan 8, 2024
2 checks passed
@hackerwins hackerwins deleted the fix-invalid-tree-conversion branch January 8, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant