Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up work after devtools mvp #734

Merged
merged 6 commits into from
Jan 24, 2024
Merged

Follow up work after devtools mvp #734

merged 6 commits into from
Jan 24, 2024

Conversation

chacha912
Copy link
Contributor

@chacha912 chacha912 commented Jan 23, 2024

What this PR does / why we need it?

  • Import devtools types from yorkie-js-sdk and remove protocol.ts
  • Center-align the panel
  • Update README.md
  • Change the Yorkie icon from 🐶 to 🐾
  • Fix the issue where the panel doesn't update on page refresh
  • Deploy using GitHub Actions (next PR)
  • Add design documentation for devtools event and lifecycle (next PR)

Any background context you want to provide?

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3b0cca9) 81.11% compared to head (de7c38d) 81.09%.

Files Patch % Lines
src/devtools/index.ts 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #734      +/-   ##
==========================================
- Coverage   81.11%   81.09%   -0.03%     
==========================================
  Files          59       59              
  Lines        4289     4289              
  Branches      838      838              
==========================================
- Hits         3479     3478       -1     
+ Misses        550      549       -1     
- Partials      260      262       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chacha912 chacha912 marked this pull request as ready for review January 24, 2024 01:56
@hackerwins hackerwins self-requested a review January 24, 2024 02:19
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. 👍

@hackerwins hackerwins merged commit c0da57b into main Jan 24, 2024
2 checks passed
@hackerwins hackerwins deleted the devtools-follow-up-mvp branch January 24, 2024 02:21
@hackerwins hackerwins changed the title Follow-up work after devtools mvp Follow up work after devtools mvp Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants