Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Tree.RemoveStyle #745

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Implement Tree.RemoveStyle #745

merged 3 commits into from
Feb 8, 2024

Conversation

raararaara
Copy link
Contributor

@raararaara raararaara commented Feb 1, 2024

What this PR does / why we need it?

  • Added Tree.RemoveStyle & RHT.remove, which was implemented in go-sdk but not js-sdk.

Any background context you want to provide?

What are the relevant tickets?

Addresses #626
Related yorkie-team/yorkie#748

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@CLAassistant
Copy link

CLAassistant commented Feb 1, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (e636b3e) 81.22% compared to head (d479d55) 81.35%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/document/crdt/rht.ts 88.57% 1 Missing and 3 partials ⚠️
src/document/json/tree.ts 55.55% 2 Missing and 2 partials ⚠️
src/document/crdt/tree.ts 92.30% 0 Missing and 1 partial ⚠️
src/document/operation/tree_style_operation.ts 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #745      +/-   ##
==========================================
+ Coverage   81.22%   81.35%   +0.13%     
==========================================
  Files          59       59              
  Lines        4292     4344      +52     
  Branches      839      852      +13     
==========================================
+ Hits         3486     3534      +48     
  Misses        547      547              
- Partials      259      263       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raararaara raararaara marked this pull request as ready for review February 5, 2024 07:07
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@hackerwins hackerwins merged commit 16bbe87 into main Feb 8, 2024
2 checks passed
@hackerwins hackerwins deleted the tree-remove-style branch February 8, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants