Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change actorID to be non-optional #747

Merged
merged 1 commit into from
Feb 4, 2024
Merged

Change actorID to be non-optional #747

merged 1 commit into from
Feb 4, 2024

Conversation

chacha912
Copy link
Contributor

What this PR does / why we need it?

When creating a document, the InitialChangeID is used as the ChangeID, ensuring that there are no cases where actorID is undefined.
Therefore, the actorID of ChangeID and TimeTicket always exists, making it non-optional.

Any background context you want to provide?

What are the relevant tickets?

Fixes #552

Checklist

  • Added relevant tests or not required
  • Didn't break anything

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e636b3e) 81.22% compared to head (c17f4b4) 81.33%.

Files Patch % Lines
src/document/change/change_id.ts 0.00% 1 Missing ⚠️
src/document/document.ts 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #747      +/-   ##
==========================================
+ Coverage   81.22%   81.33%   +0.11%     
==========================================
  Files          59       59              
  Lines        4292     4286       -6     
  Branches      839      836       -3     
==========================================
  Hits         3486     3486              
+ Misses        547      543       -4     
+ Partials      259      257       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chacha912 chacha912 marked this pull request as ready for review February 4, 2024 08:55
@hackerwins hackerwins self-requested a review February 4, 2024 09:39
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@hackerwins hackerwins merged commit bf5e651 into main Feb 4, 2024
2 checks passed
@hackerwins hackerwins deleted the refactor-actorid branch February 4, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify actor field in ChangeID to be non-optional
2 participants