Move retention-related tests to retention_test.go #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #414 +/- ##
=======================================
Coverage 46.83% 46.83%
=======================================
Files 71 71
Lines 5923 5923
=======================================
Hits 2774 2774
Misses 2846 2846
Partials 303 303 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
hackerwins
approved these changes
Sep 20, 2022
hackerwins
pushed a commit
that referenced
this pull request
Sep 29, 2022
hackerwins
pushed a commit
that referenced
this pull request
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Move retention-related tests to retention_test.go.
Recently, retention-related tests have been moved to retention_test.go. #398
This part of the code also tests whether snapshots and changes are stored in the DB as intended when using the retention feature(
--backend-snapshot-with-purging-changesflag), so I suggest moving to retention_test.go.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: