Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce sharding rules to MongoDB collections #689

Closed
wants to merge 12 commits into from

Conversation

sejongk
Copy link
Contributor

@sejongk sejongk commented Nov 24, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #673

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@sejongk sejongk added the protocol changed 📝 Whether the protocol has changed label Nov 24, 2023
@sejongk sejongk marked this pull request as draft November 24, 2023 00:59
Copy link

codecov bot commented Nov 25, 2023

Codecov Report

Attention: 235 lines in your changes are missing coverage. Please review.

Comparison is base (8a33500) 48.81% compared to head (94dffbc) 49.26%.
Report is 8 commits behind head on main.

Files Patch % Lines
server/backend/database/memory/database.go 51.09% 63 Missing and 4 partials ⚠️
server/backend/database/mongo/client.go 61.11% 63 Missing ⚠️
server/rpc/yorkie_server.go 79.77% 17 Missing and 1 partial ⚠️
client/client.go 0.00% 16 Missing ⚠️
server/backend/sync/memory/pubsub.go 42.30% 15 Missing ⚠️
server/rpc/admin_server.go 44.44% 15 Missing ⚠️
server/backend/database/mongo/registry.go 70.83% 10 Missing and 4 partials ⚠️
server/backend/database/client_info.go 69.76% 13 Missing ⚠️
api/types/resource_ref_key.go 57.14% 6 Missing ⚠️
server/backend/housekeeping/housekeeping.go 0.00% 4 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #689      +/-   ##
==========================================
+ Coverage   48.81%   49.26%   +0.44%     
==========================================
  Files          69       70       +1     
  Lines       10127    10300     +173     
==========================================
+ Hits         4944     5074     +130     
- Misses       4657     4705      +48     
+ Partials      526      521       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sejongk sejongk closed this Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol changed 📝 Whether the protocol has changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce sharding rules to MongoDB collections
1 participant