Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback MongoDB sharding rules for users collection #770

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

sejongk
Copy link
Contributor

@sejongk sejongk commented Jan 22, 2024

What this PR does / why we need it:
This PR rolls back the MongoDB sharding rules for the Users collection to prevent unnecessary sharding of the collection. Similar to the Projects collection, the Users collection is expected to store a relatively small amount of data.

Which issue(s) this PR fixes:

Addresses #673

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (6651d42) 50.72% compared to head (71c83c3) 50.73%.

Files Patch % Lines
server/backend/database/memory/database.go 68.42% 4 Missing and 2 partials ⚠️
server/backend/database/mongo/client.go 66.66% 4 Missing and 1 partial ⚠️
server/rpc/admin_server.go 70.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #770   +/-   ##
=======================================
  Coverage   50.72%   50.73%           
=======================================
  Files          70       70           
  Lines       10210    10234   +24     
=======================================
+ Hits         5179     5192   +13     
- Misses       4509     4517    +8     
- Partials      522      525    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@hackerwins hackerwins merged commit ce63c79 into main Jan 22, 2024
4 checks passed
@hackerwins hackerwins deleted the roll-back-users-collection-sharding branch January 22, 2024 08:03
@hackerwins hackerwins changed the title Roll back MongoDB sharding rules for Users collection Rollback MongoDB sharding rules for users collection Jan 22, 2024
hackerwins pushed a commit that referenced this pull request Jan 22, 2024
This commit rolls back MongoDB sharding rules for `users` collection
to avoid unnecessary collection sharding. Not only `projects`
collection but also `users` collection is expected to store relatively
less amount of data.
highcloud100 pushed a commit that referenced this pull request Jan 26, 2024
This commit rolls back MongoDB sharding rules for `users` collection
to avoid unnecessary collection sharding. Not only `projects`
collection but also `users` collection is expected to store relatively
less amount of data.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants