add wechat pay #108
add wechat pay #108
Conversation
add wechat payment
add wechat payment
add wechat payment
add wechat payment
| console.log('Pay for failure!'); | ||
| } | ||
| } | ||
| ``` |
There was a problem hiding this comment.
Correct the indention to 2 spaces please, thank you
| #### `pay` | ||
|
|
||
| ``` | ||
| async useWeChat() { |
| } else if (baseResp instanceof PayResp) { | ||
| PayResp resp = (PayResp) (baseResp); | ||
| map.putString("type", "PayReq.Resp"); | ||
| map.putString("returnkey", resp.returnKey); |
There was a problem hiding this comment.
What's the problem ?
There was a problem hiding this comment.
See this line, it causes resp.returnKey to be undefined :)
There was a problem hiding this comment.
ok, I have corrected.
There was a problem hiding this comment.
Have corrected? Did you push your code in live? I don't see any changes on this PR :(
| */ | ||
| export function pay(data) { | ||
| return new Promise((resolve, reject) => { | ||
| WeChat.pay(data,() => {}); |
There was a problem hiding this comment.
This 2nd argument is not used correctly, propose:
return new Promise((resolve, reject) => {
WeChat.pay(data, () => resolve());
}).then(() => {
emitter.on('PayReq.Resp', ...);
});But I'm not sure if there is something problems when listening "PayReq.Resp" after the callback get invoked :)
Remove the wrapping function. indention to 2 spaces
callback throws
returnkey to returnKey
|
@yorkie , I Have already submitted. |
|
All changes looks good to me, and I will keep this still open for 48 hours, and will merge and release if there are no any objection :) |
add wechat pay