Add support for floats #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
until the PR has been accepted
|
Hi @anthonywebb, thanks for the PR! Sorry about the delay in responding to your issue, there hasn't been much time for this project lately. Can you work through this checklist to complete the PR? (looks like the first three are done).
|
|
The 'F' field type is now supported in v1.1. It appears to be treated identically the same as 'N' according to the available specs, so the above coded wasn't needed (I just aliased 'N' and 'F' cases to the same code). What I did need was at least one test, and that's been added now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a file I was consuming that had data of type "F", this update allowed me to consume that data without any issue