-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme colors look wrong on custom st build #74
Comments
Do you mean background color? |
It looks like only the background color is wrong. Thank you so much for the test! |
it works on all other terminals, and even other ST builds but not mine :(( |
It seems to be a terminal issue. :( |
this is the original terminal https://st.suckless.org/ and we add patches to add new features in it |
idk how your programs sets colors, but my terminal does support true colors , i use it all the time in neovim. @bakkeby I tried your build and it doesnt have this issue, have you added any patch for it? |
Hi @siduck, in the context of st yes the alpha patch is too bright. I added these changes which makes the colours look the same as in other terminals: |
i added those, didnt work |
@siduck trying your build I see that it spits out this when superfile is started:
In st.c color reset section this is what is in your build. case 104: /* color reset, here p = NULL */
if (par == 10)
j = defaultfg;
else if (par == 11)
j = defaultbg;
else if (par == 12)
j = defaultcs;
else
j = (narg > 1) ? atoi(strescseq.args[1]) : -1;
if (xsetcolorname(j, p)) {
if (par == 104 && narg <= 1)
return; /* color reset without parameter */
fprintf(stderr, "erresc: invalid color j=%d, p=%s\n",
j, p ? p : "(null)");
} else {
/*
* TODO if defaultbg color is changed, borders
* are dirty
*/
if (j == defaultbg)
xclearwin();
redraw();
}
return; whereas in a bare st we have: case 104: /* color reset */
j = (narg > 1) ? atoi(strescseq.args[1]) : -1;
if (p && !strcmp(p, "?")) {
osc_color_response(j, 0, 1);
} else if (xsetcolorname(j, p)) {
if (par == 104 && narg <= 1) {
xloadcols();
return; /* color reset without parameter */
}
fprintf(stderr, "erresc: invalid color j=%d, p=%s\n",
j, p ? p : "(null)");
} else {
/*
* TODO if defaultbg color is changed, borders
* are dirty
*/
tfulldirt();
}
return; Looks to come from changes that NRK introduced: https://git.suckless.org/st/commit/8629d9a1da72cc18568a8f146307b0e939b77ebf.html Not sure if that is related though as I don't know how to reproduce your issue. |
This is gruvbox theme
I do have true color support in my terminal, idk why the colors show wrong 🤔
The text was updated successfully, but these errors were encountered: