event: throw on unhandled event

yoshuawuyts · Jul 21, 2015 · 78f90d8 · 78f90d8
1 parent 4015299
commit 78f90d8
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/index.js b/index.js
@@ -70,11 +70,12 @@ function dispatcher () {
           // handle cb's, and exit once done
           // (str, fn) -> null
           function retFn (action, cb) {
+            cb = cb || function () {}
             if (action) return wait(action, endWrap)
             endWrap()
 
             function endWrap () {
-              if (cb) cb()
+              cb()
               end()
             }
           }
@@ -93,8 +94,10 @@ function dispatcher () {
     // emit an error
     // any -> null
     function emitErr (err) {
-      const emitter = actions.error ? actions.error[0] : function () {}
-      emitter(err)
+      if (!actions.error) {
+        throw new Error("unhandled 'error' event")
+      }
+      actions.error[0](err)
     }
   }
 }
diff --git a/test.js b/test.js
@@ -137,5 +137,17 @@ test('.emit() should emit `error` on circular dependencies', function (t) {
   d('bin')
 })
 
+test('.emit() should throw if no error handler is bound', function (t) {
+  t.plan(1)
+  const d = barracks()
+  d.on('bin', function (data, wait) {
+    return wait('bar')
+  })
+  d.on('bar', function (data, wait) {
+    return wait('bin')
+  })
+  t.throws(d.bind(null, 'bin'), /unhandled 'error' event/)
+})
+
 function noop () {}
 noop()