Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(start): pass state and createSend to onError hook #71

Merged
merged 2 commits into from
Sep 20, 2016

Conversation

finnp
Copy link
Collaborator

@finnp finnp commented Sep 12, 2016

Hey,

I noticed that the state and createSend was actually not available in the on error hook. Added it, and now it works ☺️

@coveralls
Copy link

coveralls commented Sep 12, 2016

Coverage Status

Coverage remained the same at 98.6% when pulling 5b92119 on finnp:onerror into 4839559 on yoshuawuyts:master.

@finnp
Copy link
Collaborator Author

finnp commented Sep 12, 2016

There seems to be an issue on choo for this, closes choojs/choo#142

@YerkoPalma
Copy link

Isn't this the same as #49 ?

@finnp
Copy link
Collaborator Author

finnp commented Sep 12, 2016

Nope the change from #49 is already implemented here 0064e6a. However the arguments are missing at this place as well.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 98.606% when pulling 941f560 on finnp:onerror into 4839559 on yoshuawuyts:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 98.606% when pulling 941f560 on finnp:onerror into 4839559 on yoshuawuyts:master.

@yoshuawuyts yoshuawuyts merged commit 73dd432 into yoshuawuyts:master Sep 20, 2016
@finnp finnp deleted the onerror branch September 20, 2016 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants