Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qualify name of not found action with namespace #84

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aknuds1
Copy link

@aknuds1 aknuds1 commented Dec 14, 2016

Have send include the action's namespace when it's not found.

@coveralls
Copy link

coveralls commented Dec 14, 2016

Coverage Status

Coverage increased (+0.2%) to 98.897% when pulling 93af80a on aknuds1:include-namespace into 8437552 on yoshuawuyts:master.

test.js Outdated
const store = barracks()
const createSend = store.start()
const send = createSend('test')
send('namespace:test', (error) => {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps move send's error check to before the async code?

@coveralls
Copy link

coveralls commented Dec 14, 2016

Coverage Status

Coverage decreased (-0.2%) to 98.532% when pulling d3ba070 on aknuds1:include-namespace into 8437552 on yoshuawuyts:master.

@coveralls
Copy link

coveralls commented Dec 14, 2016

Coverage Status

Coverage decreased (-0.2%) to 98.529% when pulling 5ed315f on aknuds1:include-namespace into 8437552 on yoshuawuyts:master.

@coveralls
Copy link

coveralls commented Dec 14, 2016

Coverage Status

Coverage decreased (-0.2%) to 98.527% when pulling 6ee23e7 on aknuds1:include-namespace into 8437552 on yoshuawuyts:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 98.527% when pulling cda1025 on aknuds1:include-namespace into e9f2f30 on yoshuawuyts:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 98.527% when pulling cda1025 on aknuds1:include-namespace into e9f2f30 on yoshuawuyts:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants