Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example to do with subscriptions #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aknuds1
Copy link

@aknuds1 aknuds1 commented Mar 2, 2017

Seems to me as if the example with another call to store.start is for delayed subscription triggering, although it won't work that way since the subscriptions option is true, causing subscriptions to be triggered in the first call to store.start.

Therefore I propose the change to configure subscriptions as false in the first call to store.start.

Seems to me as if the example with another call to store.start is for delayed subscription triggering, although it won't work that way since the `subscriptions` option is true, causing subscriptions to be triggered in the first call to `store.start`.

Therefore I propose the change to configure `subscriptions` as false in the first call to `store.start`.
@coveralls
Copy link

coveralls commented Mar 2, 2017

Coverage Status

Coverage remained the same at 98.694% when pulling 9fd7ce0 on aknuds1:patch-1 into e9f2f30 on yoshuawuyts:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants