Allow for naming the rootId with no options #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now if you want to name your rootId something different, but don't pass in any options, it doesn't change the name of your rootId (see confusion in github choojs#49. This would allow someone to use ```js const app = choo() app.start('myRootNode') ``` Rather than having to use ```js const app = choo() app.start('myRootNode', {name: 'myRootNode'}) ```
|
ahh dammit - great catch! |
|
released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now if you want to name your
rootIdsomething different, but don't passin any options, it doesn't change the name of your
rootId(see confusion ingithub #49.)
This would allow someone to use
Rather than having to use