require("assert") is removed from index.js

[yavuzmester]

When browserified assert also comes in to the bundle as it is required in index.js. It is not desirable to me.

I removed the require("assert") line and replace the assert call with throw new TypeError.

[coveralls]

Coverage remained the same at 100.0% when pulling 01e21dc on yavuzmester:master into 21573d6 on yoshuawuyts:master.

[coveralls]

Coverage remained the same at 100.0% when pulling 01e21dc on yavuzmester:master into 21573d6 on yoshuawuyts:master.

[coveralls]

Coverage remained the same at 100.0% when pulling 97ea1d6 on yavuzmester:master into 21573d6 on yoshuawuyts:master.

[yavuzmester]

Even after my change, I see assert module implementation in my bundle.js. It may be caused by browserify itself. But I think it can still be helpful not to use assert there as it is not much needed.

[yoshuawuyts]

nah, let's not do this - use unassertify if you want to strip out asserts

On Fri, Nov 4, 2016 at 4:47 PM yavuzmester notifications@github.com wrote:

Even after my change, I see assert module implementation in my bundle.js.
It may be caused by browserify itself. But I think it can still be helpful
not to use assert there as it is not much needed.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#3 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACWlesyyweqLwsbt2Eq1jx4yllNF7_pyks5q6uL8gaJpZM4KpPy4
.

[yavuzmester]

ok, cool