Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target support: solaris #48

Merged
merged 2 commits into from
Dec 29, 2023
Merged

Target support: solaris #48

merged 2 commits into from
Dec 29, 2023

Conversation

onur-ozkan
Copy link
Contributor

@onur-ozkan onur-ozkan commented Dec 13, 2023

Haven't tested it yet; I will write here once I confirm it works on Solaris.

(bumped the package version too as we need a new release, please let me know if I should revert that commit)

@onur-ozkan
Copy link
Contributor Author

Tested on solaris (rust-lang/rust#118535 (comment)), works as expected.

Copy link
Collaborator

@sunfishcode sunfishcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, and thanks for testing it! Please do revert the version bump commit; I'll do a release after merging, and I'll use cargo-release to do the version bump.

Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@sunfishcode sunfishcode merged commit 195a95a into yoshuawuyts:master Dec 29, 2023
4 checks passed
@sunfishcode
Copy link
Collaborator

This is now released in fd-lock 4.0.2.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 30, 2023
…mulacrum

solaris support on bootstrap lock

With yoshuawuyts/fd-lock#48, `fd-lock` now supports Solaris. Therefore we no longer need to conditionally handle the bootstrap locks.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 30, 2023
Rollup merge of rust-lang#119413 - onur-ozkan:bump-fd-lock, r=Mark-Simulacrum

solaris support on bootstrap lock

With yoshuawuyts/fd-lock#48, `fd-lock` now supports Solaris. Therefore we no longer need to conditionally handle the bootstrap locks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants