Add missing ERROR_NO_DATA handling to NamedPipe #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @yoshuawuyts, found an interesting problem.
I needed to check that the ACLs on my named pipe were set correctly, so I used accesschk. Surprisingly, everything crashed. The error I was given: Error 232, "The pipe is being closed."
I search, find this is the define
ERROR_NO_DATA
. The documentation for ConnectNamedPipe says:With this patch,
accesschk
works, and without it, it doesn't. If you change the return value toOk(false)
it also will not work correctly.