Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrades #138

Merged
merged 9 commits into from
Jun 10, 2023
Merged

upgrades #138

merged 9 commits into from
Jun 10, 2023

Commits on Jun 10, 2023

  1. ci: update ruby versions to use latest patch version

    @yosiat
    yosiat committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    3ac9184 View commit details
    Browse the repository at this point in the history

  2. docs: npm audit fix

    @yosiat
    yosiat committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    f3c52ba View commit details
    Browse the repository at this point in the history

  3. Fix compilation warnings 

    ```
compiling ../../../../ext/panko_serializer/attributes_writer/active_record.c
../../../../ext/panko_serializer/attributes_writer/active_record.c: In function ‘active_record_attributes_writer’:
../../../../ext/panko_serializer/attributes_writer/active_record.c:163:70: warning: passing argument 3 of ‘read_attribute’ discards ‘volatile’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  163 |     volatile VALUE value = read_attribute(attributes_ctx, attribute, &isJson);
      |                                                                      ^~~~~~~
../../../../ext/panko_serializer/attributes_writer/active_record.c:88:29: note: expected ‘VALUE *’ {aka ‘long unsigned int *’} but argument is of type ‘volatile VALUE *’ {aka ‘volatile long unsigned int *’}
   88 |                      VALUE* isJson) {
      |                      ~~~~~~~^~~~~~
In file included from ../../../../ext/panko_serializer/attributes_writer/active_record.h:9,
                 from ../../../../ext/panko_serializer/attributes_writer/active_record.c:1:
```
    @yosiat
    yosiat committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    327dcaa View commit details
    Browse the repository at this point in the history

  4. Fixing some benchmarks

    @yosiat
    yosiat committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    9de465c View commit details
    Browse the repository at this point in the history

  5. Benchmarks: handle deprecations 

    Currently active support deprecations are being redirected to STDOUT which fails json parsing of output results.

Instead, we will redirect it to STDERR.
    @yosiat
    yosiat committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    8829517 View commit details
    Browse the repository at this point in the history

  6. Rakefile: add namespace for benchmarks

    @yosiat
    yosiat committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    01780dc View commit details
    Browse the repository at this point in the history

  7. Linter fixes

    @yosiat
    yosiat committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    9dc27d4 View commit details
    Browse the repository at this point in the history

  8. Lint 

    - Remove `clang-format` check on lint-ruby
- Update clang-format-action: https://github.com/jidicula/clang-format-action/releases/tag/v4.11.0
- Fix linting error (from previous commit)
    @yosiat
    yosiat committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    aa4af28 View commit details
    Browse the repository at this point in the history

  9. Remove EOL versions from CI

    @yosiat
    yosiat committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    16a6a05 View commit details
    Browse the repository at this point in the history