Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extends Express global response interface #51

Merged
merged 1 commit into from
Mar 24, 2020
Merged

extends Express global response interface #51

merged 1 commit into from
Mar 24, 2020

Conversation

Quramy
Copy link
Contributor

@Quramy Quramy commented Mar 24, 2020 •
edited

Hi. I found the following index.d.ts errors.

スクリーンショット 2020-03-24 17 04 44

I think it's better to merge Express.Response declarations.
( https://www.typescriptlang.org/docs/handbook/declaration-merging.html#merging-interfaces )

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 27ed5da on Quramy:fix-express-response-type into f488bb3 on yosuke-furukawa:master.

@yosuke-furukawa yosuke-furukawa merged commit 0734dd6 into yosuke-furukawa:master Mar 24, 2020
@yosuke-furukawa
Copy link
Owner

published v3.2.1

@Quramy Quramy deleted the fix-express-response-type branch March 24, 2020 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Quramy @coveralls @yosuke-furukawa