Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes #21

Closed
wants to merge 2 commits into from
Closed

Conversation

marocchino
Copy link
Contributor

No description provided.

@yosuke-furukawa
Copy link
Owner

Nice!
But Template Strings is not explained so much.
I would like to put new exercise like "TEMPLATE STRING LITERAL" .

@marocchino
Copy link
Contributor Author

👍

@@ -11,7 +11,7 @@ class Character {
return this.health_;
}
toString() {
return "x: " + this.x + " y: " + this.y + " health: " + this.health_;
return `x: ${this.x} y: ${this.y} health: ${this.health_}`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@yanmagale
Copy link

Nice job. Its simple to use a template strings add increament in this example is simple and important to ES6 learning.

@marocchino
Copy link
Contributor Author

I just close this PR.
Because, This PR over 1 year and other PR cover this. 🐈

@marocchino marocchino closed this Sep 7, 2016
@marocchino marocchino deleted the minor-fix branch September 7, 2016 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants