This repository has been archived by the owner on Nov 19, 2019. It is now read-only.
Week plotting stuff #135
Merged
Week plotting stuff #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th's start did not fall on the week start
yotamberk
approved these changes
Mar 9, 2019
|
Awesome! Thanks! Not ure eaither when it got changed but thanks for finding and fixing this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know why and when it got changed, but the week scale feature always stated that it depends on moment-locale and thus the week styling with 'w'.
The second commit addresse a probable bug: this.isMajor() may not actually return what you'd expect it to be, because this.current could be still set to the 'previous' value, if _repaintLabels in TimeAxis calls it.