Allow filtering of individual accounts (v2) #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing behaviour toggles all accounts from a single provider when one of them is selected in the filter dialog. This change means selections are managed by account name rather than type, in order to allow filtering on individual accounts.
|
The filter dialog is working fine. |
SuhasDissa
approved these changes
Sep 10, 2023
|
Right, then we'll merge this and fix the filtering to apply immediately with a new PR. |
Bnyro
approved these changes
Sep 10, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #238, replaces #257.
This adds the missing persistence of hidden accounts so that the filters actually work, as they don't seem to actually be stored anywhere at present (would've been useful to know that up front!). Note that groups are also lacking persistence, but I'm not immediately sure what that should look like.
I haven't made any of the UI changes suggested in #257 (comment), besides reducing the labels on each selection item to just the account names.