-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a simple audio / video trimmer. #178
Conversation
app/src/main/java/com/bnyro/recorder/ui/components/PlayerController.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/bnyro/recorder/ui/components/PlayerController.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/bnyro/recorder/ui/components/PlayerController.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/bnyro/recorder/ui/components/PlayerController.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/bnyro/recorder/ui/components/PlayerController.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/bnyro/recorder/ui/components/PlayerController.kt
Outdated
Show resolved
Hide resolved
This looks great at first view! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should place the play button below the seekbar, between start: ...
and stop: ...
to make it look less squashed. (Though it's fine if we do that somewhen later)
I also noticed the recordings tab doesn't get updated when the trimming is done (since we run it on Dispatchers.IO now), but that can be changed in a different PR.
So it's good to be merged by you from my side :)
Works great, thank you for working on that!
TrimmerModel has some problem. It doesn't reset the timestamps when opening a new file |
@Bnyro What do you prefer? Merge or Squash and Merge |
I combined the latest three commits since to clean up the commit history, now you can Merge the PR if you want :) |
Hey! I was looking through the issue history of the app and saw that you closed issue #54 saying that it's not supported by Android system APIs. But I found a system API that does support simple video trimming, and the AOSP gallery app uses it without any third-party libraries.
I added that feature to the app, and it seems to work fine. There are a few minor front-end UI/UX issues that I'll fix soon. But in the meantime, I'd love for you to take a look and let me know what you think.
Thanks!