Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.MD missing word "not" in a sentence #76

Open
julesmanson opened this issue Jan 1, 2019 · 10 comments
Open

README.MD missing word "not" in a sentence #76

julesmanson opened this issue Jan 1, 2019 · 10 comments

Comments

@julesmanson
Copy link

julesmanson commented Jan 1, 2019

Please bear with me. I am new to GitHub and git. In the very first sentence of the first paragraph (just below the page title (You Don't Need JavaScript) we have the sentence (set to bold for easy identification):

Please note these demos should be considered as CSS "Proofs of Concepts". They may have serious issues from accessibility point of view (keyboard navigation, speech synthesis, etc.), or progressive enhancement/degradation/etc.

Perhaps what you meant to say was (word in bold added):

Please note these demos should NOT be considered as CSS "Proofs of Concepts". They may have serious issues from accessibility point of view (keyboard navigation, speech synthesis, etc.), or progressive enhancement/degradation/etc.

@KOLANICH
Copy link

KOLANICH commented Jan 1, 2019

But they are proofs of concepts. This repo is not a library for production use, it just shows that JS is unneeded for most of things.

And instead of creating this issue the more clean way is to create a PR. GH built in editor can be used for that.

@stevemao
Copy link
Member

stevemao commented Jan 2, 2019

They are "Proofs of Concepts" and you should think twice before you write something like this in real projects.

@KOLANICH
Copy link

KOLANICH commented Jan 2, 2019

and you should think twice before you write something like this in real projects.

Why not? Support for lot of the features used had come into browsers long enough ago, is pretty stable and is used in production.

@stevemao
Copy link
Member

stevemao commented Jan 2, 2019

Up to you. But I don't think there's anything wrong with the sentence...

@julesmanson
Copy link
Author

"Proof of concept" depends on context (or scope if you prefer). The context cautions users about accessibility and performance (progressive degradation/enhancement issues) with respect to browser compatibility I am assuming. If that is the case then the word NOT applies. It would suggest that because these CSS methods may not universally render these methods may not be considered "proof of concepts."

@jpt4
Copy link

jpt4 commented Jan 3, 2019

This is a definitional question, in which I fear yours runs afoul of consensus usage. Independent of scope a Proof of Concept is a test, example, or implementation otherwise less featureful than an enterprise grade product, and as such may bear the deficiencies enumerated in the subsequent sentence. Insofar as this repository does not exclude projects on the basis of, e.g., accessibility issues, the blanket caveat that they might be Proofs of Concept is warranted.

@julesmanson
Copy link
Author

If the goal is accessibility and performance across a wide range of devices and clients then this is NOT a

proof of concept.

@KOLANICH
Copy link

KOLANICH commented Jan 3, 2019

If the goal is accessibility and performance

They are not the goals of this repo:

They may have serious issues from accessibility point of view (keyboard navigation, speech synthesis, etc.), or progressive enhancement/degradation/etc.

@julesmanson
Copy link
Author

Oh gawd I give up. I was only trying to help. Regardless this is one outstanding series of repos.

@cht8687
Copy link
Member

cht8687 commented Sep 16, 2019

@julesmanson
Thanks for your attention to details!
PR is welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants